This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

作者 sdaoden
收信人 giampaolo.rodola, pitrou, sdaoden
日期 2011-02-28.14:49:28
SpamBayes Score 2.1890605e-08
Marked as misclassified
Message-id <20110228144837.GD74538@sherwood.local>
In-reply-to <1298903836.51.0.0360506310736.issue11351@psf.upfronthosting.co.za>
内容
Will this do?  Otherwise feel free to adjust the patch the way 
Python needs it, i'll learn from that, then, for possible future 
things.  (I need to go down now.)

On Mon, Feb 28, 2011 at 02:37:16PM +0000, Antoine Pitrou wrote:
> 
> Antoine Pitrou <pitrou@free.fr> added the comment:
> 
> Your patch is not cleaned up. There are strange things like:
> 
> +            ret ^= ret;
> 
> (while would you xor an off_t?)
> 
> and
> 
> +        do {    off_t x = (*buf)[i].len;
> +                (*iov)[i].iov_len = x;
> +                ret += x;
> +        } while (0);
文件
文件名 上传时间
issue11351.patch sdaoden, 2011-02-28.14:49:28
历史
日期 用户 动作 参数
2011-02-28 14:49:30sdaoden修改recipients: + sdaoden, pitrou, giampaolo.rodola
2011-02-28 14:49:28sdaoden链接issue11351 messages
2011-02-28 14:49:28sdaoden创建