This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

作者 nadeem.vawda
收信人 MizardX, antlong, asvetlov, eric.araujo, mdehoon, nadeem.vawda, niemeyer, pitrou, rhettinger, wrobell, xuanji
日期 2011-04-02.23:34:21
SpamBayes Score 2.1081759e-07
Marked as misclassified
Message-id <1301787262.79.0.2065758755.issue5863@psf.upfronthosting.co.za>
In-reply-to
内容
Thanks for the review. I've made most of the changes you suggested, but there's
one thing I wanted to check about:

> - instead of "int(size)", use "size = size.__index__()" so as to forbid floats

The tests for readline() and readlines() expect a TypeError if size is None.
Calling size.__index__() in this case raises an AttributeError instead. Should I
change the tests to expect an AttributeError? Alternatively, something like this
would more closely match the behaviour of the old code:

    try:
        size = size.__index__()
    except AttributeError:
        raise TypeError("Integer argument expected")
历史
日期 用户 动作 参数
2011-04-02 23:34:22nadeem.vawda修改recipients: + nadeem.vawda, rhettinger, niemeyer, mdehoon, pitrou, wrobell, eric.araujo, asvetlov, MizardX, antlong, xuanji
2011-04-02 23:34:22nadeem.vawda修改messageid: <1301787262.79.0.2065758755.issue5863@psf.upfronthosting.co.za>
2011-04-02 23:34:21nadeem.vawda链接issue5863 messages
2011-04-02 23:34:21nadeem.vawda创建