消息 [153131] - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

作者	nadeem.vawda
收信人	eric.araujo, nadeem.vawda, proyvind, tarek
日期	2012-02-11.18:28:32
SpamBayes Score	0.0047120736
Marked as misclassified	否
Message-id	<1328984913.38.0.797072619928.issue5411@psf.upfronthosting.co.za>
In-reply-to

内容
> This not-so-bad patch adds lzma compression support to the shutil functions, under the 'xztar' name. Please review. Functionally, the patch looks good to me. There are some docstrings that should probably be updated, though: - _make_tarball (the 'compress' argument) - make_archive - _unpack_tarfile - unpack_archive > Ideally, tarfile should have an attribute to expose what compression formats are available, then shutil would reuse that, and packaging would just call shutil. +1

> This not-so-bad patch adds lzma compression support to the shutil functions, under the 'xztar' name.  Please review.

Functionally, the patch looks good to me. There are some docstrings that
should probably be updated, though:

- _make_tarball (the 'compress' argument)
- make_archive
- _unpack_tarfile
- unpack_archive


> Ideally, tarfile should have an attribute to expose what compression formats are available, then shutil would reuse that, and packaging would just call shutil.

+1

历史
日期	用户	动作	参数
2012-02-11 18:28:33	nadeem.vawda	修改	recipients: + nadeem.vawda, tarek, eric.araujo, proyvind
2012-02-11 18:28:33	nadeem.vawda	修改	messageid: <1328984913.38.0.797072619928.issue5411@psf.upfronthosting.co.za>
2012-02-11 18:28:32	nadeem.vawda	链接	issue5411 messages
2012-02-11 18:28:32	nadeem.vawda	创建