消息 [77681]
> - why do you use PyLong_FromSize_t rather than PyInt_FromSize_t?
I choosed to use consistent result type. But now I would prefer int :-) I see
that PyInt_FromSize_t() returns a long if the value doesn't fit in an int. So
it's correct.
> - isn't the if (ndigits == 0) check redundant?
I'm paranoid: if _PyLong_NumBits() fails but the number is zero, the function
may crash. But this case is impossible: _PyLong_NumBits() can only fails with
an OverflowError.
Can you fix these two issues (use PyInt_FromSize_t and remove the if)? |
|
| 日期 |
用户 |
动作 |
参数 |
| 2008-12-12 18:03:15 | vstinner | 修改 | recipients:
+ vstinner, loewis, rhettinger, terry.reedy, mark.dickinson, fredrikj |
| 2008-12-12 18:03:14 | vstinner | 链接 | issue3439 messages |
| 2008-12-12 18:03:14 | vstinner | 创建 | |
|