Skip to content

Heads-up: LumaGlass fork (likaia/MonitorControl) has missing source file for its Tahoe HUD fix #1890

Description

@kenkanuma

Context: #1782 points people to the LumaGlass fork (likaia/MonitorControl) as a possible workaround for the missing Tahoe OSD slider. That issue is now locked and likaia's repo has Issues/Discussions disabled, so posting here instead.

Looked into LumaGlass as a candidate fix. Found a problem: MonitorControl/Support/BrightnessHUDController.swift is referenced in project.pbxproj (Sources build phase, AB10C000.../AB10C001...) but the file itself doesn't exist in any commit on any branch of that repo:

git log --all --diff-filter=A --name-only | grep -i hud
→ only CUSTOM_BRIGHTNESS_HUD_PLAN.md, no .swift file

Likely cause: the fork's .gitignore contains a large templated block (looks like a Jenkins-home template) with a root-level blanket /* ignore + whitelist exceptions, around line ~4670. It appears to silently match and exclude this new root-level Swift file:

git check-ignore -v MonitorControl/Support/BrightnessHUDController.swift
→ .gitignore:4670:/*    MonitorControl/Support/BrightnessHUDController.swift

Impact:

  • The fork doesn't build from source as committed (missing-file compile error).
  • The actual implementation of the macOS 26 HUD fix — the fork's main feature — isn't in the public source, only in the prebuilt DMG/ZIP release assets linked from the GitHub release. Can't be reviewed/audited from the repo alone.

Rest of the diff against upstream (MenuHandler/SliderHandler UI rewrite, Sparkle feed repoint, MediaKeyTap dependency swap) checked out fine — no risky APIs, no entitlement changes, dependency fork is byte-identical to MonitorControl's own MediaKeyTap fork. This missing file is the one open concern.

@likaia — flagging in case you want to fix the .gitignore/commit the missing file. Mainly posting here for visibility since the fork's own issue tracker is closed and #1782 is locked.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    informationIssue contains some important general information

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions