Skip to content

Copying of extensionDefinitions when generating a new builder #3427

Description

@RoKKim

Describe the bug
The graphql.schema.GraphQLSchema#newSchema(graphql.schema.GraphQLSchema) method does not copy the graphql.schema.GraphQLSchema.Builder#extensionDefinitions when generating a new builder from the existing GraphQLSchema. Is there a reason for this? Do I need to redefine the extensions when generating a new builder?

An easy fix would probably be:

return new Builder()
        ...
        .extensionDefinitions(existingSchema.getExtensionDefinitions())
        ...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions