Skip to content

Change generator to warn about invalid argument names #1464

Description

@rcjsuen

I had the following in my descriptor.json file:

          "args": {
            "result": {
              "isReturn": true
            },
            "opts:": {
              "isOptional": true
            }

I ran npm run generateJson and npm run generateNativeCode many times but the opts argument wouldn't become optional in the generated C++ file. I finally realized I made a typo. I named the argument opts: instead of opts! :(

We should change the generator so that it will generate warnings if a specified argument's name doesn't match what's declared in libgit2.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions