Skip to content

Increase minimum macOS version #53561

Closed
Closed
Increase minimum macOS version#53561
Labels
buildIssues and PRs related to Node.js builds or CI infrastructure.macosIssues and PRs related to the macOS platform.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

Description

@anonrig
anonrig
opened on Jun 23, 2024

std::format("hello {}", "world") is not available before 13.3, and we support 11. Is there any reason not to update minimum macOS version in the next major?

  • macOS 11 release date -> 2020
  • macOS 13 release date -> 2022
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/c++/v1/__format/formatter_floating_point.h:73:32: error: 'to_chars' is unavailable: introduced in macOS 13.3
  to_chars_result __r = _VSTD::to_chars(__first, __last, __value, __fmt, __precision);

../../src/node_file.cc:2159:25: note: in instantiation of function template specialization 'std::format<char *>' requested here
    auto message = std::format("src and dest cannot be the same %s", src.out());

cc @nodejs/build @nodejs/tsc

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    buildIssues and PRs related to Node.js builds or CI infrastructure.macosIssues and PRs related to the macOS platform.staleIssues and PRs marked stale due to inactivity and scheduled for automatic closure.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions