Timezone Europe/Berlin does not have DST transitions #268

Activity

1. thekid

   added

   php

   on Apr 17, 2021
2. thekid commented on Apr 17, 2021

   

   thekid

   on Apr 17, 2021

   MemberAuthor

   More actions

   Most probably related to php/php-src@091c092, which is a huge diff (52,924 additions and 29,617 deletions).

   I've opened a PHP bug: https://bugs.php.net/bug.php?id=80963
3. thekid commented on Apr 18, 2021

   

   thekid

   on Apr 18, 2021

   MemberAuthor

   More actions

   Quoting from the bug:

   This is a tricky one. The data format that the library uses has changed, and will now only contain a list of transitions up until the last time the rules changed.

   For America/New_York, that was in 2007, and Europe/London, in 1996
4. thekid

   added 2 commits that reference this issue on Apr 18, 2021

   Remove PHP 8.1 for the moment

   ...

   5ca1b61

   Ignore tests related to timezone transitions for the moment

   ...

   2be9b33
5. thekid commented on Apr 25, 2021

   

   thekid

   on Apr 25, 2021

   MemberAuthor

   More actions

   The tests in question have been disabled for the time being by only running them with PHP up until 8.1.0-dev:

   $ grep -Hirn -A 1 8.1.0-dev src/test/php/ | cut -d / -f 6-
   unittest/util/CalendarTest.class.php:89:  #[Test, Action(eval: 'new RuntimeVersion("<8.1.0-dev")')]
   unittest/util/CalendarTest.class.php-90-  public function testCalendarDSTBegin() {
   --
   unittest/util/CalendarTest.class.php:100:  #[Test, Action(eval: 'new RuntimeVersion("<8.1.0-dev")')]
   unittest/util/CalendarTest.class.php-101-  public function testCalendarDSTBeginByDate() {
   --
   unittest/util/CalendarTest.class.php:111:  #[Test, Action(eval: 'new RuntimeVersion("<8.1.0-dev")')]
   unittest/util/CalendarTest.class.php-112-  public function testCalendarDSTBeginUS() {
   --
   unittest/util/CalendarTest.class.php:121:  #[Test, Action(eval: 'new RuntimeVersion("<8.1.0-dev")')]
   unittest/util/CalendarTest.class.php-122-  public function testCalendarDSTEnd() {
   --
   unittest/util/TimeZoneTest.class.php:43:  #[Test, Action(eval: 'new RuntimeVersion("<8.1.0-dev")')]
   unittest/util/TimeZoneTest.class.php-44-  public function previousTransition() {
   --
   unittest/util/TimeZoneTest.class.php:52:  #[Test, Action(eval: 'new RuntimeVersion("<8.1.0-dev")')]
   unittest/util/TimeZoneTest.class.php-53-  public function previousPreviousTransition() {
   --
   unittest/util/TimeZoneTest.class.php:62:  #[Test, Action(eval: 'new RuntimeVersion("<8.1.0-dev")')]
   unittest/util/TimeZoneTest.class.php-63-  public function previousNextTransition() {
   --
   unittest/util/TimeZoneTest.class.php:72:  #[Test, Action(eval: 'new RuntimeVersion("<8.1.0-dev")')]
   unittest/util/TimeZoneTest.class.php-73-  public function nextTransition() {
6. thekid commented on Aug 21, 2021

   

   thekid

   on Aug 21, 2021

   MemberAuthor

   More actions

   https://bugs.php.net/bug.php?id=80963 was closed on August 8th, retesting with current PHP verifies this once again works as expected.
7. thekid

   closed this as completedon Aug 21, 2021
8. thekid

   added a commit that references this issue on Aug 21, 2021

   Remove skipping tests for PHP 8.1.0

   ...

   fc7b0aa