Skip to content
This repository was archived by the owner on Jul 13, 2022. It is now read-only.

Use floats for all EGS values - #642

Merged
P1sar merged 1 commit into
mainfrom
david/fix/handle-EGS-floats
May 17, 2021
Merged

P1sar merged 1 commit into
mainfrom
david/fix/handle-EGS-floats

Conversation

@ansermino

@ansermino ansermino commented May 15, 2021

Copy link
Copy Markdown
Contributor

Description

The API returns floats not ints for the gas values. This also adds an error log if fetching or parsing fails to make sure it's clear to the operator.

Related Issue Or Context

Closes: #

How Has This Been Tested? Testing details.

Updated existing test to use a float. Tested it against the actual live endpoint locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in chainbridge-docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@ansermino
ansermino requested a review from P1sar May 16, 2021 22:31
@P1sar
P1sar merged commit 6f55404 into main May 17, 2021
@P1sar
P1sar deleted the david/fix/handle-EGS-floats branch May 17, 2021 07:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants