[release/v7.6.6] Use Custom Validation Policy for vPack Pipeline - #27914
Merged
Justin Chung (jshigetomi) merged 1 commit intoSep 1, 2026
Merged
Conversation
Co-authored-by: Justin Chung <chungjustin@microsoft.com> Copilot-Session: 99e6a033-65fd-4a39-9a71-2ce9b7657c10 (cherry picked from commit bc487bf)
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Backport to release/v7.6.6 that unblocks the vPack pipeline by disabling the injected OneBranch CodeSign validation and instead re-signing the full vPack payload with the Windows build tools certificate, then validating it against a repository-owned “tools-only” CodeSign policy.
Changes:
- Disable injected CodeSign validation for the vPack build job and add an explicit CodeSign validation step using a custom policy file.
- Extend the
obp-file-signing.ymltemplate to support overriding the third-party signing profile and optionally signing all binaries with that profile (used by vPack). - Add a repository-owned custom CodeSign policy XML and remove the prior global SDL custom policy toggle from the official vPack pipeline.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .pipelines/templates/stages/PowerShell-vPack-Stages.yml | Disables injected validation, signs the full vPack payload with the tools cert, then validates with a custom policy and post-processes SARIF. |
| .pipelines/templates/obp-file-signing.yml | Adds parameters to override third-party signing profile and optionally sign all binaries with that profile. |
| .pipelines/PowerShell-vPack-Official.yml | Removes globalSdl.useCustomPolicy in favor of explicit per-job validation in the stage template. |
| .config/codesignpolicy.xml | Introduces the repository-managed “tools-only” CodeSign validation policy used by the vPack stage. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+266
to
+274
| $failures = @( | ||
| foreach ($run in $sarif.runs) { | ||
| foreach ($result in $run.results) { | ||
| if ($result.ruleId -ne 'CodeSign.MatchingPolicy') { | ||
| $result | ||
| } | ||
| } | ||
| } | ||
| ) |
Aditya Patwardhan (adityapatwardhan)
approved these changes
Sep 1, 2026
Justin Chung (jshigetomi)
merged commit Sep 1, 2026
97b5570
into
PowerShell:release/v7.6.6
34 of 35 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27911 to
release/v7.6.6.Signs the complete vPack payload with the Windows build tools certificate and validates it with the merged repository-owned tools-only CodeSign policy.