[release/v7.6.6] Update LocProject.json to list each English resource file directly - #27937
Merged
Patrick Meinecke (SeeminglyScience) merged 1 commit intoSep 1, 2026
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Patrick Meinecke (SeeminglyScience)
September 1, 2026 15:21
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Backports the localization configuration fix to release/v7.6.6 by replacing recursive/wildcard .resx discovery with an explicit, per-file list of English source resources, and adds a Pester validation test intended to keep LocProject.json in sync with the repo’s actual resource files.
Changes:
- Replaces wildcard-based
SourceFileentries inLocalize/LocProject.jsonwith an explicit list of English.resxfiles and correspondingCopyOption/OutputPathvalues. - Adds a Pester test suite to validate
LocProject.jsonLocItemsentries exist on disk and that the total count matches the repo’s English.resxinventory.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
Localize/LocProject.json |
Expands LocItems to explicitly enumerate each English .resx file (no wildcards), aligning with localization pipeline expectations. |
test/powershell/engine/ResourceValidation/LocProject.Tests.ps1 |
Adds CI validation intended to ensure LocProject.json stays synchronized with the repo’s resource files (currently has issues that need fixing). |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| try { | ||
| Push-Location -Path $srcDir | ||
| $resDirs = Get-ChildItem 'resources' -Recurse -Directory | ForEach-Object FullName |
Comment on lines
+23
to
+25
| $realSourceFile = Join-Path $repoRoot $sourceFile | ||
|
|
||
| Test-Path -Path $realSourceFile | Should -BeTrue |
Justin Chung (jshigetomi)
approved these changes
Sep 1, 2026
Patrick Meinecke (SeeminglyScience)
merged commit Sep 1, 2026
2da5785
into
PowerShell:release/v7.6.6
36 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27751 to release/v7.6.6
Triggered by Patrick Meinecke (@SeeminglyScience) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Lists each English resource file explicitly in LocProject.json instead of using a wildcard pattern that was recursively matching localized subfolders, causing translated resources to be incorrectly treated as source English resources by the localization pipeline (root cause of the BOM issue in #27921).
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Cherry-picked cleanly with no conflicts. Original PR added tests validating LocProject.json content stays in sync with actual resource files in the repo.
Risk
REQUIRED: Check exactly one box.
Fixes an incorrect wildcard pattern in LocProject.json that caused localized .resx files to be recursively discovered and misidentified as default English resources, which is believed to be the root cause of a BOM generation failure seen in the #27756 backport (#27921). Change is limited to localization pipeline configuration and does not affect runtime code.