Skip to content

[release/v7.6.6] Update AppxManifest.xml to only declare en-US for the <Resources> element - #27941

Merged
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:release/v7.6.6from
daxian-dbw:7.6
Sep 1, 2026
Merged

[release/v7.6.6] Update AppxManifest.xml to only declare en-US for the <Resources> element#27941
Dongbo Wang (daxian-dbw) merged 1 commit into
PowerShell:release/v7.6.6from
daxian-dbw:7.6

Conversation

@daxian-dbw

@daxian-dbw Dongbo Wang (daxian-dbw) commented Sep 1, 2026

Copy link
Copy Markdown
Member

Backport of #27939 to release/v7.6.6

Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)

Original CL Label: CL-BuildPackaging

/cc @PowerShell/powershell-maintainers

Impact

REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Update AppxManifest.xml to only declare en-US for the <Resources> element. We cannot add the other languages until the MS Store related texts are localized.

Customer Impact

  • Customer reported
  • Found internally

Regression

REQUIRED: Check exactly one box.

  • Yes
  • No

This is not a regression.

Testing

Cherry-picked cleanly with no conflicts. Original PR added tests validating LocProject.json content stays in sync with actual resource files in the repo.

Risk

REQUIRED: Check exactly one box.

  • High
  • Medium
  • Low

Copilot AI lite review requested due to automatic review settings September 1, 2026 17:46
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This backport updates the MSIX/AppX package manifest to declare only en-US in the <Resources> section, aligning the Store manifest with the current state of localized Store-facing strings.

Changes:

  • Remove non-en-US <Resource> language declarations from assets/AppxManifest.xml.
  • Remove an outdated CI-related comment from build.psm1.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
build.psm1 Removes a comment near initialization/StrictMode (no functional logic change).
assets/AppxManifest.xml Restricts declared package resources to en-US only.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread assets/AppxManifest.xml
@daxian-dbw Dongbo Wang (daxian-dbw) added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Sep 1, 2026
@daxian-dbw
Dongbo Wang (daxian-dbw) merged commit 2a50996 into PowerShell:release/v7.6.6 Sep 1, 2026
40 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants