[release/v7.6.6] Produce satellite assemblies in Windows release build and properly remove them when they are not required - #27943
Merged
Dongbo Wang (daxian-dbw) merged 2 commits intoSep 1, 2026
Conversation
Dongbo Wang (daxian-dbw)
requested review from
a team and
Justin Chung (jshigetomi)
as code owners
September 1, 2026 18:01
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Dongbo Wang (daxian-dbw)
September 1, 2026 18:01
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR (a backport to release/v7.6.6) adjusts the Windows build/publish flow to better control satellite assembly output and configures the Windows hosted pipeline to ensure .NET has access to culture data needed for localization-related build steps.
Changes:
- Updates
build.psm1to conditionally restrict satellite resource languages during publish and remove resulting satellite assembly directories when they aren’t required. - Sets
DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=0in the Windows hosted build template to ensure cultural data is available during the build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| build.psm1 | Adds conditional satellite-assembly cleanup and tweaks publish properties for satellite resource languages. |
| .pipelines/templates/windows-hosted-build.yml | Ensures .NET globalization isn’t forced into invariant mode on Windows hosted builds. |
Suppressed comments (1)
build.psm1:767
- The comment about
-SMAOnlyis now inaccurate because the new satellite-assembly cleanup block runs before theif ($SMAOnly) { return }early-exit. Either move the cleanup below the-SMAOnlyreturn, or update this comment so it matches the current control flow.
Write-LogGroupEnd -Title "Build PowerShell"
# No extra post-building task will run if '-SMAOnly' is specified, because its purpose is for a quick update of S.M.A.dll after full build.
if ($SMAOnly) {
return
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Patrick Meinecke (SeeminglyScience)
approved these changes
Sep 1, 2026
Dongbo Wang (daxian-dbw)
merged commit Sep 1, 2026
899d8c9
into
PowerShell:release/v7.6.6
41 of 42 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27938 to release/v7.6.6
Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-BuildPackaging
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
DOTNET_SYSTEM_GLOBALIZATION_INVARIANTto0in Windows builds allow .NET SDK to produce satellite assemblies for PowerShell.build.psm1to remove PowerShell satellite assemblies properly when they are not required.Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Cherry-picked cleanly with no conflicts. Original PR added tests validating LocProject.json content stays in sync with actual resource files in the repo.
Risk
REQUIRED: Check exactly one box.