[release/v7.6.6] Fix the localization tests for Release Automation - #27945
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoSep 2, 2026
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Dongbo Wang (daxian-dbw)
September 2, 2026 05:32
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped to test skip-logic for a specific pipeline environment and don’t affect product/runtime behavior.
Pull request overview
Updates localization-related Pester tests on release/v7.6.6 to avoid failures when run under the Release Automation pipeline, where certain repo artifacts and installed-package contents differ from a normal repo checkout.
Changes:
- Skip
LocProject.jsonvalidation tests when running under Release Automation (whereLocProject.jsonisn’t available). - Conditionally skip satellite-assembly validation in Release Automation unless the installed PowerShell appears to be an MSIX install.
- Harden
LocProject.jsonloading by using-ErrorAction Stopfor file read and JSON parsing.
File summaries
| File | Description |
|---|---|
| test/powershell/engine/ResourceValidation/LocProject.Tests.ps1 | Adds Release Automation skip logic and stricter file/JSON error handling for LocProject validation tests. |
| test/powershell/engine/ResourceValidation/LocalizedResource.Tests.ps1 | Adds Release Automation MSIX detection to decide whether to run satellite assembly assertions. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Patrick Meinecke (SeeminglyScience)
approved these changes
Sep 2, 2026
Dongbo Wang (daxian-dbw)
merged commit Sep 2, 2026
d208fb8
into
PowerShell:release/v7.6.6
36 checks passed
Dongbo Wang (daxian-dbw)
deleted the
backport/release/v7.6.6/27944-fcdb9f0c3
branch
September 2, 2026 15:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #27944 to release/v7.6.6
Triggered by Dongbo Wang (@daxian-dbw) on behalf of Dongbo Wang (@daxian-dbw)
Original CL Label: CL-Test
/cc @PowerShell/powershell-maintainers
Impact
REQUIRED: Choose either Tooling Impact or Customer Impact (or both). At least one checkbox must be selected.
Tooling Impact
Fixes LocProject.json and satellite-assembly Pester tests that fail in the Release Automation pipeline. LocProject.json tests now skip when running under Release Automation (file isn't available there), and satellite assembly tests now only run when the installed PowerShell is an MSIX package (which is the only package type that ships localized resource assemblies).
Customer Impact
Regression
REQUIRED: Check exactly one box.
This is not a regression.
Testing
Test-only change (Pester test files). Verified by running the updated tests both in a normal repo checkout (tests still execute/pass) and simulating the Release Automation environment variable (PIPELINE_REPOSITORY_NAME=Release-Automation) to confirm the tests are properly skipped.
Risk
REQUIRED: Check exactly one box.
Change is limited to test skip-logic in two Pester test files; no product/runtime code is touched. Narrow, well-scoped change with no customer-facing impact.