pr_file_map.py: Use a human-readable date format - #15357
Merged
Merged
Conversation
Use a human-readable date format.
for more information, see https://pre-commit.ci
cclauss
enabled auto-merge (squash)
September 16, 2026 08:57
Member
Author
|
@priya-sundaram-dev, please review. |
priya-sundaram-dev
approved these changes
Sep 16, 2026
priya-sundaram-dev
left a comment
Contributor
There was a problem hiding this comment.
LGTM — nice readability pass on the script, thanks for picking it up. Walked through each change:
- Human-readable timestamp (
{datetime.now(UTC):%d %b %Y at %H:%M} {UTC}→ "16 Sep 2026 at 09:00 UTC") reads far better in the rendered report than the raw ISO string. 👍 directory_onlyas a comma-joined- #1, #2, ...list item renders much cleaner in the Markdown than the space-separated run.scripts/pr_file_map.pyin the usage examples matches whatscript_display_path()actually emits now — good consistency fix.if root := git_root():is functionally equivalent here sincegit_root()only ever returnsNoneor a real (non-empty, truthy)Path, so dropping the explicitis not Noneis safe and cleaner.
All checks green. Approving.
poyea
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a human-readable date format.
Describe your change