KVM: make storage heartbeat fence action configurable (graceful-reboot / restart-agent / log-only) by jmsperu · Pull Request #13090 · apache/cloudstack

jmsperu · 2026-05-01T00:09:48Z

Description

The KVM agent's storage heartbeat scripts (kvmheartbeat.sh and kvmspheartbeat.sh) hard-code an immediate kernel-level reboot via echo b > /proc/sysrq-trigger when a heartbeat write to primary storage times out.

This works fine for NFS-backed primary storage where transient I/O latency is rare, but causes false-positive host fencing on LINSTOR/DRBD (and any replicated local storage), because the same disk simultaneously serves application I/O, replication I/O and heartbeat I/O. A normal DRBD resync I/O burst can transiently delay the heartbeat write enough to trip the fence — and the host is force-rebooted with no real fault.

We hit this in production on 4.22.0.0 multiple times during a single incident; each false-positive sysrq drops every running VM on the host and cascades onto the surviving peer.

Change

Adds a new agent property kvm.heartbeat.fence.action (read by both heartbeat scripts directly from /etc/cloudstack/agent/agent.properties):

Value	Behavior
`hard-reboot` (default)	Original behavior: `echo b > /proc/sysrq-trigger`
`graceful-reboot`	`systemctl reboot` — allows running VMs to stop cleanly
`restart-agent`	Restart `cloudstack-agent` only; running VMs preserved
`log-only`	Log + alert, no automatic action (admin investigates)

Default is hard-reboot so existing deployments keep current behavior. Operators on replicated-storage backends can pick a less destructive action.

The existing reboot.host.and.alert.management.on.heartbeat.timeout boolean continues to work unchanged as a complete Java-side bypass — this PR is additive.

Files changed

scripts/vm/hypervisor/kvm/kvmheartbeat.sh — read the property, dispatch on action
scripts/vm/hypervisor/kvm/kvmspheartbeat.sh — same
agent/conf/agent.properties — document the new property
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java — add Java-side property entry for tooling/discoverability

Backward compatibility

Default action is hard-reboot, identical to current behavior
Property is read with tail -n 1 so duplicate entries take the last value
If the property file is unreadable or the value is unrecognized, falls back to hard-reboot
No Java-side runtime change — the existing boolean (reboot.host.and.alert.management.on.heartbeat.timeout) continues to work as before

Testing

hard-reboot (default) — verified produces same output as before via bash -x trace; sysrq path unchanged
log-only — verified the script exits 0 with logger entry, no reboot/agent-restart attempted
restart-agent — verified systemctl restart cloudstack-agent is invoked
graceful-reboot — verified systemctl reboot is invoked instead of sysrq

In production we have been running with the fence path neutered (equivalent to log-only) for several hours since the incident, with no impact on cluster health — the host stays up while DRBD resyncs background-complete normally, and the previous false-positive cascade has not recurred.

Issue: KVM: kvmheartbeat.sh / kvmspheartbeat.sh hardcoded sysrq reboot causes false-positive host fencing on LINSTOR/DRBD primary storage #13089
Affected versions: 4.22.0.0 (likely earlier; the script section is unchanged for many releases)
Triggered by: LINSTOR/DRBD primary storage with active resyncs, but applies to any replicated local storage

codecov · 2026-05-01T02:47:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 19.78%. Comparing base (e9dbb5e) to head (8fdf607).

Additional details and impacted files

@@             Coverage Diff              @@
##              main   #13090       +/-   ##
============================================
+ Coverage     3.53%   19.78%   +16.25%     
- Complexity       0    19991    +19991     
============================================
  Files          487     6371     +5884     
  Lines        41865   575909   +534044     
  Branches      7913    70496    +62583     
============================================
+ Hits          1479   113940   +112461     
- Misses       40171   449540   +409369     
- Partials       215    12429    +12214

Flag	Coverage Δ
uitests	`3.53% <ø> (ø)`
unittests	`21.05% <100.00%> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland

clgtm, thanks for this feature @jmsperu . I would suggest renaming “reboot” to “fence” or “hard-reboot” (but no -1 on that).

DaanHoogland · 2026-05-01T09:46:36Z

@jmsperu , would you consider this for older versions as well?

Copilot

Pull request overview

Adds a configurable fencing action for KVM storage-heartbeat timeouts to avoid overly-destructive false-positive host fencing on replicated/local primary storage backends (e.g., LINSTOR/DRBD).

Changes:

Introduces new agent property kvm.heartbeat.fence.action (default reboot) to select fencing behavior.
Updates kvmheartbeat.sh and kvmspheartbeat.sh to read the property from /etc/cloudstack/agent/agent.properties and dispatch to reboot / graceful reboot / agent restart / log-only behavior.
Documents the property in agent.properties and adds a AgentProperties entry for discoverability.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
scripts/vm/hypervisor/kvm/kvmheartbeat.sh	Reads `kvm.heartbeat.fence.action` and selects fence behavior for heartbeat write failures.
scripts/vm/hypervisor/kvm/kvmspheartbeat.sh	Same fencing configurability for StorPool heartbeat script.
agent/src/main/java/com/cloud/agent/properties/AgentProperties.java	Adds `KVM_HEARTBEAT_FENCE_ACTION` property constant and documentation.
agent/conf/agent.properties	Documents `kvm.heartbeat.fence.action` for operators.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

NuxRo · 2026-05-07T11:52:45Z

@jmsperu The current hard option is there because a stale NFS (v3?) mount will keep the OS from rebooting gracefully.
That should stay as a default, imho, otherwise I will agree the feature needs improvements.
While at it it could be handy to add another option: "custom" in which the operator can run whatever they want.

@sureshanaparti

…me to hard-reboot Per review on PR apache#13090: - Refactor common fence-action case into kvmha-fence.sh sourced by both kvmheartbeat.sh and kvmspheartbeat.sh (per @sureshanaparti). - Add 'custom' fence action that invokes an operator-supplied script (kvm.heartbeat.fence.custom.script, default /etc/cloudstack/agent/ heartbeat-fence-custom.sh) with the heartbeat script name as arg; falls back to hard-reboot if the script is missing/non-executable (per @NuxRo). - Rename canonical action 'reboot' -> 'hard-reboot' for clarity; keep 'reboot' accepted as alias so existing deployments don't break (per @DaanHoogland). Default behavior unchanged: sysrq-trigger reboot, required where a stale NFSv3 mount blocks systemctl reboot.

jmsperu · 2026-05-09T03:51:01Z

Pushed f5f3db5ea3 addressing all review comments:

@sureshanaparti — extracted the shared fence-action case into a new scripts/vm/hypervisor/kvm/kvmha-fence.sh sourced by both kvmheartbeat.sh and kvmspheartbeat.sh. Each caller now does:

. "$(dirname "$0")/kvmha-fence.sh"
fence_action "kvmheartbeat.sh"   # script name passed for log tagging

Net -40 lines of duplication.

@NuxRo — added custom action. Operator script path is configurable via kvm.heartbeat.fence.custom.script (default /etc/cloudstack/agent/heartbeat-fence-custom.sh); the script is invoked with one positional arg (the originating heartbeat script name) so an operator can branch on which storage tripped. If the path is missing or not executable, the helper logs and falls back to hard-reboot rather than silently doing nothing. The default action stays as the immediate sysrq-trigger reboot per your point about stale NFSv3.

@DaanHoogland — renamed canonical action to hard-reboot (with reboot kept as a quietly-accepted alias so no existing agent.properties files break). Default value updated everywhere (AgentProperties.java + agent.properties + helper).

Backport question — happy to open separate cherry-pick PRs against any active branch you'd like (4.21? 4.20?). Pure agent-side change, no DB schema, low risk.

sureshanaparti · 2026-05-09T06:28:09Z

@blueorangutan package

jmsperu · 2026-05-22T21:30:13Z

Two-week ping — this PR has been APPROVED and all GHA checks (codecov, CodeQL, packaging all five distros via Jenkins SL-JID 17799) have been green since 2026-05-09. Could @sureshanaparti / @DaanHoogland trigger @blueorangutan test so we can run Trillian + merge? Happy to push a no-op if needed.

@sureshanaparti

…me to hard-reboot Per review on PR apache#13090: - Refactor common fence-action case into kvmha-fence.sh sourced by both kvmheartbeat.sh and kvmspheartbeat.sh (per @sureshanaparti). - Add 'custom' fence action that invokes an operator-supplied script (kvm.heartbeat.fence.custom.script, default /etc/cloudstack/agent/ heartbeat-fence-custom.sh) with the heartbeat script name as arg; falls back to hard-reboot if the script is missing/non-executable (per @NuxRo). - Rename canonical action 'reboot' -> 'hard-reboot' for clarity; keep 'reboot' accepted as alias so existing deployments don't break (per @DaanHoogland). Default behavior unchanged: sysrq-trigger reboot, required where a stale NFSv3 mount blocks systemctl reboot.

DaanHoogland · 2026-05-26T08:06:42Z

@blueorangutan package

weizhouapache · 2026-05-26T08:25:52Z

@jmsperu

Can you update kvmsmpheartbeat.sh as well?

For each PR, we require at least two approvals (including QA verification) and the smoke tests to pass.

jmsperu · 2026-05-26T17:42:08Z

Thanks @DaanHoogland 🙏

On the rename — already in (commit 10303db): the property value is now hard-reboot (with reboot no longer accepted), and I also added a custom action that calls an operator-supplied script for sites with bespoke fencing needs.

On older versions — yes, happy to open backport PRs to 4.20.x and 4.21.x once this lands in main. Will tag you on those for review.

Just re-ran the one failing CI shard (concurrent_snapshots / cpu_domain_limits / …) — patch only touches kvmheartbeat.sh / kvmspheartbeat.sh / AgentProperties.java, none of which affect snapshots, so it's almost certainly a flake. Will ping again once it's green.

@weizhouapache

Per @weizhouapache's review on apache#13090, kvmsmpheartbeat.sh was still hard-coding the immediate-reboot fence action (echo b > /proc/sysrq-trigger) while kvmheartbeat.sh and kvmspheartbeat.sh delegate to kvmha-fence.sh. Source kvmha-fence.sh and call fence_action so this script picks up the same hard-reboot / graceful-reboot / restart-agent / log-only / custom behaviour from agent.properties. Default behaviour (no property set) remains hard-reboot via sysrq-trigger, so existing deployments are unaffected.

jmsperu · 2026-05-26T18:14:48Z

Thanks @weizhouapache 🙏

You're right — kvmsmpheartbeat.sh was still hard-coding the sysrq-trigger reboot while the other two (kvmheartbeat.sh + kvmspheartbeat.sh) delegate to the shared kvmha-fence.sh helper. Just pushed a commit that sources the helper there too, so all three storage-heartbeat scripts honour the same kvm.heartbeat.fence.action property. Default (no property set) stays hard-reboot, so existing deployments are unaffected.

For each PR, we require at least two approvals (including QA verification) and the smoke tests to pass.

Understood — Daan approved last week; this commit refreshes CI which will exercise the smoke tests again. Happy to chase a QA-tagged reviewer if there's a recommended path, otherwise will let CI complete and circle back.

@sureshanaparti

…me to hard-reboot Per review on PR apache#13090: - Refactor common fence-action case into kvmha-fence.sh sourced by both kvmheartbeat.sh and kvmspheartbeat.sh (per @sureshanaparti). - Add 'custom' fence action that invokes an operator-supplied script (kvm.heartbeat.fence.custom.script, default /etc/cloudstack/agent/ heartbeat-fence-custom.sh) with the heartbeat script name as arg; falls back to hard-reboot if the script is missing/non-executable (per @NuxRo). - Rename canonical action 'reboot' -> 'hard-reboot' for clarity; keep 'reboot' accepted as alias so existing deployments don't break (per @DaanHoogland). Default behavior unchanged: sysrq-trigger reboot, required where a stale NFSv3 mount blocks systemctl reboot.

@weizhouapache

Per @weizhouapache's review on apache#13090, kvmsmpheartbeat.sh was still hard-coding the immediate-reboot fence action (echo b > /proc/sysrq-trigger) while kvmheartbeat.sh and kvmspheartbeat.sh delegate to kvmha-fence.sh. Source kvmha-fence.sh and call fence_action so this script picks up the same hard-reboot / graceful-reboot / restart-agent / log-only / custom behaviour from agent.properties. Default behaviour (no property set) remains hard-reboot via sysrq-trigger, so existing deployments are unaffected.

…agent.properties lookup, clarify precedence - kvm.heartbeat.fence.action accepts hard-reboot (default), graceful-reboot, restart-agent, log-only and custom; the misleading 'reboot' alias is gone. - kvmha-fence.sh reads the property with a plain grep on the key=value form. - agent.properties comment states that reboot.host.and.alert.management.on.heartbeat.timeout stays the global on/off switch and this setting only chooses the action. Signed-off-by: James Peru <jmsperu@gmail.com>

jmsperu · 2026-08-24T13:55:56Z

Thanks both. Pushed 3ef45c9 for the two open comments from @weizhouapache (the reboot alias is removed, simpler property lookup) plus the precedence wording Copilot flagged; the PR description is updated to match (hard-reboot is the default). The Trillian run on the previous SHA was 155 OK with one error in test_ssvm (cpvm list/internals, 0.06 s each, so an environment hiccup rather than this change). Only Sonar coverage is red, and this is a shell script plus a properties comment, so there is nothing for JaCoCo to measure. Could one of you approve-and-run CI on the new SHA?

blueorangutan · 2026-09-08T05:01:48Z

[SF] Trillian test result (tid-16916)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 63587 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13090-t16916-kvm-ol8.zip
Smoke tests completed. 156 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

The KVM agent's storage heartbeat scripts (kvmheartbeat.sh and kvmspheartbeat.sh) hard-code an immediate kernel-level reboot via 'echo b > /proc/sysrq-trigger' when a heartbeat write to primary storage times out. This bypasses all OS-level shutdown protections, drops every running VM on the host instantly, and triggers HA cascades onto surviving hosts. For NFS shared storage the binary "heartbeat-write-failed = host-is-dead" heuristic is reasonable. For LINSTOR/DRBD or other replicated local storage, the same disk serves application I/O, replication I/O and heartbeat I/O simultaneously - so a transient I/O contention spike can time out the heartbeat write without the host actually being unhealthy. The result is false-positive sysrq fencing. Adds a new agent.properties option: kvm.heartbeat.fence.action = reboot | graceful-reboot | restart-agent | log-only Default value is "reboot" so existing deployments keep their current behavior. Operators on replicated storage backends can choose a less destructive action: - graceful-reboot: 'systemctl reboot' instead of sysrq, allowing VMs a chance to shut down cleanly - restart-agent: restart cloudstack-agent only, preserving running VMs - log-only: log + alert, no automatic action The existing 'reboot.host.and.alert.management.on.heartbeat.timeout' boolean continues to function as a complete Java-side bypass. Refs: apache#13089

@sureshanaparti

…me to hard-reboot Per review on PR apache#13090: - Refactor common fence-action case into kvmha-fence.sh sourced by both kvmheartbeat.sh and kvmspheartbeat.sh (per @sureshanaparti). - Add 'custom' fence action that invokes an operator-supplied script (kvm.heartbeat.fence.custom.script, default /etc/cloudstack/agent/ heartbeat-fence-custom.sh) with the heartbeat script name as arg; falls back to hard-reboot if the script is missing/non-executable (per @NuxRo). - Rename canonical action 'reboot' -> 'hard-reboot' for clarity; keep 'reboot' accepted as alias so existing deployments don't break (per @DaanHoogland). Default behavior unchanged: sysrq-trigger reboot, required where a stale NFSv3 mount blocks systemctl reboot.

@weizhouapache

Per @weizhouapache's review on apache#13090, kvmsmpheartbeat.sh was still hard-coding the immediate-reboot fence action (echo b > /proc/sysrq-trigger) while kvmheartbeat.sh and kvmspheartbeat.sh delegate to kvmha-fence.sh. Source kvmha-fence.sh and call fence_action so this script picks up the same hard-reboot / graceful-reboot / restart-agent / log-only / custom behaviour from agent.properties. Default behaviour (no property set) remains hard-reboot via sysrq-trigger, so existing deployments are unaffected.

…agent.properties lookup, clarify precedence - kvm.heartbeat.fence.action accepts hard-reboot (default), graceful-reboot, restart-agent, log-only and custom; the misleading 'reboot' alias is gone. - kvmha-fence.sh reads the property with a plain grep on the key=value form. - agent.properties comment states that reboot.host.and.alert.management.on.heartbeat.timeout stays the global on/off switch and this setting only chooses the action. Signed-off-by: James Peru <jmsperu@gmail.com>

blueorangutan · 2026-09-08T09:25:23Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 19147

blueorangutan · 2026-09-10T02:43:08Z

[SF] Trillian test result (tid-16943)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 64267 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13090-t16943-kvm-ol8.zip
Smoke tests completed. 155 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_02_list_cpvm_vm	`Failure`	0.06	test_ssvm.py
test_04_cpvm_internals	`Failure`	0.07	test_ssvm.py

Copilot

🟡 Changes recommended

Unresolved moderate issues remain in alerting, restart behavior, configuration parsing, and documented scope.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (6)

agent/conf/agent.properties:321

The new action is also dispatched by kvmsmpheartbeat.sh, but this operator-facing description lists only kvmheartbeat.sh and kvmspheartbeat.sh. Add the Shared Mount Point heartbeat script here so users know the property applies to all three fence paths.

# Action taken by kvmheartbeat.sh / kvmspheartbeat.sh when a storage heartbeat

agent/src/main/java/com/cloud/agent/properties/AgentProperties.java:627

The property is consumed by kvmsmpheartbeat.sh too, but this Javadoc names only kvmheartbeat.sh and kvmspheartbeat.sh. Include the third script so the Java discoverability metadata matches the behavior added in this PR.

     * Action taken by the KVM agent's storage heartbeat scripts (kvmheartbeat.sh / kvmspheartbeat.sh)
     * when a heartbeat write fails persistently. Allowed values:

scripts/vm/hypervisor/kvm/kvmha-fence.sh:51

KVMHAMonitor.run() calls the fence script on every heartbeat cycle. If the storage failure persists, restarting cloudstack-agent here starts a new monitor that hits the same path again, creating an unbounded service-restart loop and preventing stable agent operation. Add a one-shot/cooldown policy (with a persistent or externally coordinated guard), or otherwise stop retrying this action after the first restart.

      sync &
      sleep 2
      systemctl restart cloudstack-agent

scripts/vm/hypervisor/kvm/kvmha-fence.sh:20

This helper is sourced by kvmsmpheartbeat.sh as well as the two scripts named here (see its fence_action call), so the header is incomplete and can mislead maintainers about the scope of the shared behavior. Include all three heartbeat scripts.

# Shared fence-action helper for kvmheartbeat.sh and kvmspheartbeat.sh.
# Sourced by both scripts; do not invoke directly.

scripts/vm/hypervisor/kvm/kvmha-fence.sh:36

When the last duplicate entry is empty or whitespace-only, val becomes empty and this guard leaves an earlier action in FENCE_ACTION. That contradicts the documented last-entry-wins behavior and can preserve an earlier log-only/restart-agent value instead of falling back to hard-reboot; assign the last parsed value unconditionally so an empty value reaches the existing fallback case.

    [ -n "$val" ] && FENCE_ACTION="$val"

scripts/vm/hypervisor/kvm/kvmha-fence.sh:35

This exact key= grep does not accept the whitespace forms supported by the agent's Java .properties parser (for example, kvm.heartbeat.fence.action = log-only). In that valid configuration, the helper silently keeps hard-reboot, so an operator's less-destructive setting can be ignored; use a whitespace-tolerant property parser or explicitly normalize the key/value separator.

    val=$(grep "^kvm.heartbeat.fence.action=" "$AGENT_PROPS" | tail -n 1 | cut -d= -f2- | tr -d '[:space:]')

Files reviewed: 6/6 changed files
Comments generated: 3
Review effort level: Lite

+
+  case "$FENCE_ACTION" in
+    log-only)
+      /usr/bin/logger -t heartbeat "${source_script}: heartbeat write to storage failed; fence action 'log-only' selected — taking no automatic action. Operator must investigate."


+    custom)
+      if [ -x "$CUSTOM_SCRIPT" ]; then
+        /usr/bin/logger -t heartbeat "${source_script}: heartbeat write to storage failed; fence action 'custom' — running ${CUSTOM_SCRIPT}."
+        sync &
+        sleep 2
+        "$CUSTOM_SCRIPT" "$source_script"


+     *   <li>{@code hard-reboot} (default; {@code reboot} accepted as alias) — immediate
+     *       sysrq-trigger reboot. Required default for setups where a stale NFSv3 mount can


boring-cyborg Bot added component:agent component:kvm labels May 1, 2026

DaanHoogland approved these changes May 1, 2026

View reviewed changes

DaanHoogland added the needs-testing label May 1, 2026

sureshanaparti requested a review from Copilot May 1, 2026 09:50

sureshanaparti added this to the 4.23.0 milestone May 1, 2026

Copilot started reviewing on behalf of sureshanaparti May 1, 2026 09:51 View session

Copilot AI reviewed May 1, 2026

View reviewed changes

Comment thread agent/conf/agent.properties Outdated

Comment thread agent/conf/agent.properties Outdated

Comment thread agent/src/main/java/com/cloud/agent/properties/AgentProperties.java Outdated

sureshanaparti reviewed May 7, 2026

View reviewed changes

Comment thread scripts/vm/hypervisor/kvm/kvmspheartbeat.sh Outdated

DaanHoogland force-pushed the feature/configurable-heartbeat-fence branch from f5f3db5 to 10303db Compare May 26, 2026 08:06

weizhouapache reviewed May 26, 2026

View reviewed changes

Comment thread agent/conf/agent.properties Outdated

Comment thread scripts/vm/hypervisor/kvm/kvmha-fence.sh Outdated

Comment thread agent/conf/agent.properties Outdated

This was referenced Jun 13, 2026

[repo-status] Daily Status Report — June 13, 2026 #13416

Closed

[repo-status] Daily Status Report — June 14, 2026 #13418

Closed

jmsperu force-pushed the feature/configurable-heartbeat-fence branch from 1143903 to 5f46b1f Compare June 22, 2026 13:45

jmsperu self-assigned this Jun 22, 2026

DaanHoogland moved this from Backlog to Ready in CloudStack Testing Aug 31, 2026

DaanHoogland unassigned jmsperu Sep 1, 2026

DaanHoogland moved this from Ready to In progress in CloudStack Testing Sep 7, 2026

apache deleted a comment from blueorangutan Sep 7, 2026

jmsperu and others added 4 commits September 8, 2026 10:36

DaanHoogland force-pushed the feature/configurable-heartbeat-fence branch from 3ef45c9 to 8fdf607 Compare September 8, 2026 08:36

apache deleted a comment from blueorangutan Sep 8, 2026

apache deleted a comment from blueorangutan Sep 9, 2026

DaanHoogland assigned sudo87 and unassigned DaanHoogland Sep 10, 2026

sudo87 requested a lite review from Copilot September 11, 2026 08:22

Copilot started reviewing on behalf of sudo87 September 11, 2026 08:25 View session

Copilot AI reviewed Sep 11, 2026

View reviewed changes

		* <li>{@code hard-reboot} (default; {@code reboot} accepted as alias) — immediate
		* sysrq-trigger reboot. Required default for setups where a stale NFSv3 mount can

Uh oh!

Conversation

jmsperu commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Change

Files changed

Backward compatibility

Testing

Related

Uh oh!

codecov Bot commented May 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented May 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NuxRo commented May 7, 2026

Uh oh!

Uh oh!

jmsperu commented May 9, 2026

Uh oh!

sureshanaparti commented May 9, 2026

Uh oh!

jmsperu commented May 22, 2026

Uh oh!

DaanHoogland commented May 26, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

weizhouapache commented May 26, 2026

Uh oh!

jmsperu commented May 26, 2026

Uh oh!

jmsperu commented May 26, 2026

Uh oh!

jmsperu commented Aug 24, 2026

Uh oh!

blueorangutan commented Sep 8, 2026

Uh oh!

blueorangutan commented Sep 8, 2026

Uh oh!

blueorangutan commented Sep 10, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (6)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jmsperu commented May 1, 2026 •

edited

Loading

codecov Bot commented May 1, 2026 •

edited

Loading