CCKS: fix scaling failures for clusters without a default service offering - #14138
Draft
Pearl1594 wants to merge 2 commits into
Draft
CCKS: fix scaling failures for clusters without a default service offering#14138Pearl1594 wants to merge 2 commits into
Pearl1594 wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 4.22 #14138 +/- ##
============================================
+ Coverage 17.86% 18.01% +0.15%
- Complexity 16037 16466 +429
============================================
Files 5928 5928
Lines 534479 540156 +5677
Branches 65410 67410 +2000
============================================
+ Hits 95468 97295 +1827
- Misses 428173 431839 +3666
- Partials 10838 11022 +184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This was
linked to
issues
Sep 11, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR #14122 #14148
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Deployed a CKS cluster with dedicated service offerings for the node types (v1.35.6) - this isnt reproducible via UI, because via UI passing the common service offering is mandatory (so the kubernetes_cluster.service_offering_id column is never null). Scaled the offering to a default/common one - successfully scaled. (for KVM the cluster needs to be stopped prior upgrade)
Also tried upgrading the cluster - form v1.35.6 to 1.36.2 - Successfully upgraded
How did you try to break this feature and the system with this change?