ui: improve related global config popup - #14149
Conversation
Consider child configs in the list for related configs and show an alert that there may be other dependent configs. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
Enhances the related global configuration popup to include child configurations and warn users that the list may be incomplete.
Changes:
- Merges prefix-matched and parent-linked configurations.
- Adds an informational alert and English localization.
File summaries
| File | Summary |
|---|---|
ui/src/views/setting/ConfigurationValue.vue |
Expands related-configuration lookup and displays the alert. |
ui/public/locales/en.json |
Adds the alert message translation. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14149 +/- ##
============================================
+ Coverage 3.71% 19.88% +16.17%
- Complexity 0 20137 +20137
============================================
Files 487 6371 +5884
Lines 41992 576837 +534845
Branches 7942 70629 +62687
============================================
+ Hits 1558 114719 +113161
- Misses 40208 449584 +409376
- Partials 226 12534 +12308
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
sudo87
left a comment
There was a problem hiding this comment.
lgtm, tested by toggling agent.lb.enabled configuration and it shows up agent.load.threshold related configuration.
Description
Follow-up for #13965
Consider child configs in the list for related configs and show an alert that there may be other dependent configs.
Apart from prefix matching, now it also lists configs with
parentparam.Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
related-global-config-improvement.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?