[7.x backport] fix: avoid removable fields as decorator evaluation hosts - #18225
Open
nyan-left wants to merge 2 commits into
Open
[7.x backport] fix: avoid removable fields as decorator evaluation hosts#18225nyan-left wants to merge 2 commits into
nyan-left wants to merge 2 commits into
Conversation
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @nyan-left. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
Insufficient dataNot enough activity yet to make a reliable assessment. This is an automated analysis by AgentScan |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/62080 |
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18224.
On Babel 7, the TypeScript transform can remove uninitialized fields when
allowDeclareFieldsis false. If one of those fields hosts a memoized decorator assignment, the assignment is removed with it and the generated class throwsTypeError: A decorator must be a function.This skips removable fields when selecting a host and uses the existing temporary computed field when necessary, and this is obviously going to solve the problem without changing decorator evaluation order.
Regression tests cover stacked member-expression decorators, class decorator ordering, and declaration fields using Babel 7's TypeScript behavior.