docs(get-funds): list testnet faucets inline instead of linking to a redirect loop - #1963
Open
kriss39 wants to merge 1 commit into
Open
docs(get-funds): list testnet faucets inline instead of linking to a redirect loop#1963kriss39 wants to merge 1 commit into
kriss39 wants to merge 1 commit into
Conversation
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed? Why?
docs/base-chain/network-information/network-faucets.mdxis in.mintignoreand redirects to/get-started/get-funds, butget-fundsstill links to it ("Get free test ETH and USDC from the Base faucets"). On the live site that link 308s straight back to the page the reader is already on, so the faucet list is unreachable from anywhere.Two more pages point at the same redirect and end up on
get-fundswithout the information they promised: the "Get Testnet Funds" card onget-started/base-chainand the "faucets listed here" tip onspecifications/reference/smart-contracts.This PR:
get-funds.mdx(CDP, thirdweb, Alchemy, QuickNode, Chainstack, ethfaucet.com — the entries from the old page whose links still resolve; Bware, LearnWeb3 and ethereum-ecosystem.com currently return 5xx/402 and were left out)/get-started/get-funds#testnet-base-sepoliaNo pages are added and
docs.jsonis untouched, so this shouldn't trip the Get Started IA gate.Notes to reviewers
If the intent of #1772 was to drop partner faucet listings entirely, the alternative is to keep just the CDP faucet bullet and drop the rest — the important part is that the "Base faucets" link stops looping.
How has it been tested?
node scripts/lint-mdx.json the three files,node scripts/validate-docs-structure.jsandnode scripts/check-terminology.jspass. Every faucet URL in the new list was fetched and returns 200.Screenshots
N/A (one bullet list replaces one bullet; two link targets change)