caddyhttp: dedupe MatchPath godoc for %* wildcards - #7932
Open
locker95 wants to merge 1 commit into
Open
Conversation
|
|
Member
|
Could you sign the CLA and add our required assistance disclosure? |
Author
|
Added the assistance disclosure on the PR. I'll get the CLA signed if it's still pending — think I signed before but happy to re-do it. |
Member
|
Make sure the email you used to commit with matches one of the emails on your github account. CLA is still not signed. |
The JSON docs surface this comment twice with nearly the same wording. Keep one paragraph that covers both examples. Signed-off-by: Dean Chen <862469039@qq.com>
Author
|
Good catch — commit author was on a qq.com address. Rewrote it to my GitHub noreply email and force-pushed. Signing the CLA with that next if the badge still lags. |
locker95
force-pushed
the
docs/path-matcher-dedupe
branch
from
August 10, 2026 08:44
12e7ca9 to
bce87c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path matcher docs on the website (and the godoc that feeds them) had two near-identical paragraphs about
%*. Folded them into one that still shows both examples.Fixes caddyserver/website#484
Assistance Disclosure
No AI tooling on this change — small godoc edit by hand.