fix(mmap): support read-only - #10782
Merged
kripken merged 1 commit intoMar 28, 2020
Merged
Conversation
kripken
reviewed
Mar 28, 2020
kripken
left a comment
Member
There was a problem hiding this comment.
Nice, thanks @petersalomonsen ! Just the one comment.
| #if FILESYSTEM && SYSCALLS_REQUIRE_FILESYSTEM | ||
| var stream = FS.getStream(info.fd); | ||
| SYSCALLS.doMsync(addr, stream, len, info.flags, info.offset); | ||
| if (info.prot & 0x02) { |
Member
There was a problem hiding this comment.
I believe the constant can be {{{ cDefine('PROT_WRITE') }}}.
Contributor
Author
There was a problem hiding this comment.
thanks for reviewing @kripken . Replaced with the constant now.
petersalomonsen
force-pushed
the
fix-mmap-readonly
branch
from
March 28, 2020 05:15
93730a2 to
f70b166
Compare
only do msync on munmap if PROT_WRITE is set
petersalomonsen
force-pushed
the
fix-mmap-readonly
branch
from
March 28, 2020 11:18
f70b166 to
40fb8f2
Compare
kripken
approved these changes
Mar 28, 2020
kripken
left a comment
Member
There was a problem hiding this comment.
Perfect, thanks @petersalomonsen !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
only do msync on munmap if PROT_WRITE is set