fix: pass memory ownership to host functions - #2
Merged
Merged
Conversation
zshipko
approved these changes
Sep 20, 2024
zshipko
left a comment
There was a problem hiding this comment.
Looks good!
Unrelated, but I'm excited to try out the cpp-pdk, I appreciate the thought put into the design!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1
UniqueHandle<T>automatically frees their extism memory when they go out of scope so memory passed into those host functions is now allocated to the non-owningHandle<T>bool var_set(const std::string_view name, const imports::RawHandle value);was replaced withtemplate <typename T = char> bool var_set(const std::string_view name, UniqueHandle<T> unique_value);as it now need ownership of the value. It is not freed by C++ as.releaseis called just like it is done for output.