Conversation
Member
|
@YHC66 Please run |
dill~=0.3.0 keeps Python 3.14 users on dill 0.3.9, which does not support 3.14's changes to pickle. Serializing a UDF with dill.dumps(udf, recurse=True), as Transformation.to_proto() and StreamFeatureView.to_proto() do, fails with "TypeError: _Pickler._batch_setitems() missing 1 required positional argument: 'obj'" whenever the UDF refers to a module-level global such as pd, so on-demand feature views cannot be applied on 3.14. dill added Python 3.14 support in 0.4.0 and made it formal in 0.4.1. Allow it. The lock files still resolve dill 0.3.9 for 3.10-3.12, and pixi.lock only records the new requirement (from `pixi lock`). Signed-off-by: Yihang Chen <yhc0720@berkeley.edu>
Signed-off-by: Yihang Chen <yhc0720@berkeley.edu>
YHC66
force-pushed
the
fix-dill-python-3-14
branch
from
September 25, 2026 15:47
44b56ef to
ab57414
Compare
Author
|
Done: rebased on current master and regenerated all the lock files with the |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
dill~=0.3.0keeps Python 3.14 users on dill 0.3.9, which doesn't support 3.14's changes topickle. Serializing a UDF withdill.dumps(udf, recurse=True), asTransformation.to_proto()andStreamFeatureView.to_proto()do, fails as soon as the UDF refers to a module-level global, such aspdin a pandas UDF:So an on-demand feature view written like the docs example can't be applied on 3.14:
dill added Python 3.14 support in 0.4.0 and made it formal in 0.4.1. This widens the requirement to
dill>=0.3.0,<0.5and records it inpixi.lock(regenerated withpixi lock; the locked dill stays at 0.3.9). Thesdk/python/requirementslock files are unchanged and still resolve dill 0.3.9 for 3.10–3.12, so CI keeps testing the same versions; installs on 3.14 now get a dill that works.A UDF serialized with dill 0.3.9 loads with 0.4.1 and the other way round (checked on 3.12), so existing registries and mixed client/server versions keep working.
Which issue(s) this PR fixes:
No existing issue.
Checks
git commit -s)Testing Strategy
Misc
CI runs Python 3.10–3.12, which is why this doesn't show up there, and I didn't add a test for the same reason: the existing on-demand feature view tests cover it on 3.14. Locally, on macOS:
-e ".[test,k8s,aws,gcp]": the ODFV, transformation and stream feature view unit tests (103 tests in 11 files) have 15 failures with theTypeErrorabove on dill 0.3.9, and none on dill 0.4.1. Five further tests need pyspark, which I didn't install, and fail either way.sdk/python/requirements/py3.12-ci-requirements.txt: the fullsdk/python/tests/unitrun gives 2773 passed, 44 skipped with dill 0.3.9, and the same with dill 0.4.1 swapped in.