ci: fix the propagation of TEST_USER_GITHUB - #1446
Merged
Merged
Conversation
sudoforge
marked this pull request as draft
May 18, 2025 00:52
Contributor
Author
|
this effectively "re-enables" the |
MichaelMure
force-pushed
the
Ia1ad61e54e305bb073efc6853738d3eed81d576c
branch
from
September 14, 2026 16:15
de7def3 to
3cf190e
Compare
MichaelMure
marked this pull request as ready for review
September 14, 2026 16:48
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved blocking issues were identified.
Pull request overview
This PR fixes GitHub test credential propagation in CI and improves bridge test cleanup and GitHub API handling.
Changes:
- Corrects CI variable and secret propagation.
- Adds interrupt-aware cleanup and readiness polling.
- Improves label handling and secondary rate-limit recognition.
File summaries
| File | Summary |
|---|---|
bridge/gitlab/import_test.go |
Simplifies backend cleanup. |
bridge/gitlab/export_test.go |
Adds interrupt-aware cleanup. |
bridge/github/import_test.go |
Removes conflicting interrupt cleanup. |
bridge/github/import_integration_test.go |
Removes conflicting interrupt cleanup. |
bridge/github/export.go |
Improves label synchronization and existing-label handling. |
bridge/github/export_test.go |
Adds readiness polling and interrupt-safe cleanup. |
bridge/github/config_test.go |
Removes obsolete Travis-specific skipping. |
bridge/github/client.go |
Recognizes secondary rate-limit errors. |
.github/workflows/build-and-test.yml |
Corrects credential propagation for the selected matrix job. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Sep 16, 2026
MichaelMure
force-pushed
the
Ia1ad61e54e305bb073efc6853738d3eed81d576c
branch
2 times, most recently
from
September 17, 2026 16:31
ad22c52 to
d99846e
Compare
A typo in the reference to the repository-level `TEST_USER_GITHUB` variable was causing export tests under //bridge/github to be skipped. This change resolves this issue. Change-Id: Ia1ad61e54e305bb073efc6853738d3eed81d576c
MichaelMure
force-pushed
the
Ia1ad61e54e305bb073efc6853738d3eed81d576c
branch
from
September 17, 2026 16:31
d99846e to
025f64c
Compare
MichaelMure
enabled auto-merge
September 17, 2026 16:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A typo in the reference to the repository-level
TEST_USER_GITHUBvariable was causing export tests under //bridge/github to be skipped.
This change resolves this issue.
Change-Id: Ia1ad61e54e305bb073efc6853738d3eed81d576c