fix: reserve KotlinX and PHP runtime names - #3514
Merged
Merged
Conversation
Generated-output differences160 files differ — 106 modified, 54 new, 0 deleted |
Generated-output differences160 files differ — 106 modified, 54 new, 0 deleted |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KotlinX Serialization imports annotations and helper types into generated files, and PHP reserves
Serializableas a built-in interface. Models with those names therefore produced invalid Kotlin annotations and types or a PHP class redeclaration.Reserve the affected runtime names and cover them in the shared keyword fixtures.
Tests:
npm run lintPATH=/opt/homebrew/opt/kotlin/libexec/bin:$PATH CPUs=2 QUICKTEST=true FIXTURE=kotlinx,schema-kotlinx npm run test:fixtures(141 tests)CPUs=2 QUICKTEST=true FIXTURE=php,schema-php npm run test:fixtures(141 tests)Production diff: 7 added lines.