Skip to content

Https config for issue #44 - #48

Merged
greengerong merged 3 commits into
greengerong:masterfrom
kgujral:master
May 29, 2018
Merged

greengerong merged 3 commits into
greengerong:masterfrom
kgujral:master

Conversation

@kgujral

@kgujral kgujral commented May 11, 2018

Copy link
Copy Markdown

No description provided.

@kgujral

kgujral commented May 11, 2018

Copy link
Copy Markdown
Author

I have created this new PR. Finally all checks have passed :)

@kgujral

kgujral commented May 11, 2018

Copy link
Copy Markdown
Author

Everything looks good. Please merge this one whenever you have the time.

@thoop

thoop commented May 14, 2018

Copy link
Copy Markdown
Contributor

@greengerong can you merge this? Thanks!

@kgujral

kgujral commented May 15, 2018

Copy link
Copy Markdown
Author

Hi, I don't think I have the access to merge the PR. You'll have to do it

@thoop

thoop commented May 15, 2018

Copy link
Copy Markdown
Contributor

Sorry, I was tagging @greengerong so that he would get a notification and see this. @greengerong can you merge this? He's the one that has merge access.

@kgujral

kgujral commented May 16, 2018

Copy link
Copy Markdown
Author

Ohh sorry I misread it! My Bad

@greengerong
greengerong merged commit 7db72b9 into greengerong:master May 29, 2018
@greengerong

Copy link
Copy Markdown
Owner

Thanks

@thoop

thoop commented May 29, 2018

Copy link
Copy Markdown
Contributor

@greengerong Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants