Don't use read-write accounts for the tests - #2425
Merged
Merged
Conversation
Don't write in plaintext the password of an account which has full control over the repository. Instead use an account with read-only access.
The assembla failure we were seeing referred to a private repository, which is not what is there at the moment. This reverts 1fd21b0
vmg
pushed a commit
that referenced
this pull request
Jun 16, 2014
Don't use read-write accounts for the tests
phatblat
pushed a commit
to phatblat/libgit2
that referenced
this pull request
Sep 13, 2014
Don't use read-write accounts for the tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't write out the passwords, but use read-only accounts to make sure these credentials cannot change what's in the repos.