Merged
Conversation
Member
|
Good catch. Thanks! |
ethomson
approved these changes
Jun 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version 1.9.0 introduced a memory leak when using the new FIPS-compliant mode (-DUSE_SHA256=OpenSSL-FIPS).
The culprit turned out to be the
ctx->c = NULL;line added togit_hash_sha256_finalfunction, which too hastily cleans up a pointer. Because of that, the cleanup function call to EVP_MD_CTX_free(nullptr) doesn't have any effect and the memory is never freed.The same applies to SHA1 fips mode.