Check object lengths against headers in read_loose - #7236
Merged
Merged
Conversation
Avoid a buffer overrun when an object's header specifies a short length but the body is longer (fix #7177). Take care to preserve the behavior that too-short object bodies are not an error but get zero-padded.
Add a test that looks up an invalid, truncated object, that is shorter than the advertised length.
ethomson
force-pushed
the
ethomson/lengths
branch
from
April 30, 2026 21:59
8cafda5 to
a1c807c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picking #7178 with a test to validate