Skip to content

Call __post_init__ from msgspec.structs.replace/copy.replace #1000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcrist merged 1 commit into from
Apr 8, 2026
Merged

Call __post_init__ from msgspec.structs.replace/copy.replace #1000

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/msgspec/_core.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7994,6 +7994,8 @@ Struct_replace(
}
}

if (Struct_post_init(struct_type, out) < 0) goto error;

if (is_gc && should_untrack && MS_IS_TRACKED(out))
PyObject_GC_UnTrack(out);
return out;
Expand Down
28 changes: 14 additions & 14 deletions tests/unit/test_struct.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2379,6 +2379,20 @@ class Test(msgspec.Struct):
assert sys.getrefcount(x2) == x2_count + 1
del t2

def test_replace_calls_post_init(self, replace):
count = 0

class Ex(Struct):
def __post_init__(self):
nonlocal count
count += 1

x1 = Ex()
assert count == 1
x2 = replace(x1)
assert x1 == x2
assert count == 2


class TestAsDictAndAsTuple:
def test_asdict(self):
Expand Down Expand Up @@ -2663,17 +2677,3 @@ def __post_init__(self):
x2 = x1.__copy__()
assert x1 == x2
assert count == 1

def test_post_init_not_called_on_replace(self):
count = 0

class Ex(Struct):
def __post_init__(self):
nonlocal count
count += 1

x1 = Ex()
assert count == 1
x2 = msgspec.structs.replace(x1)
assert x1 == x2
assert count == 1
Loading