fix leak in typenode_collect_literal - #1021
Merged
Merged
Conversation
jcrist
approved these changes
Apr 13, 2026
jcrist
left a comment
Member
There was a problem hiding this comment.
Thanks!
Just noting severity for anyone following along - this leak would only ever leak references to an empty tuple (an immortal singleton on all python versions, effectively leaking nothing). It also only shows up in the case of a Literal with no arguments, which is already a user-error.
Not saying we shouldn't fix it! Some people just associate leaks like this with major issues, and this one is very very minor.
Member
Author
|
Yeah, it's virtually impossible to hit, and completely irrelevant in 3.12+ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix leak caused by a missing
Py_DECREFon an error path intypenode_collect_literal. Only possible on Python <3.12, as empty tuples are immortalized from 3.12 onwards.