Inline common msgpack encode dispatch - #298
Merged
Merged
Conversation
This selectively inlines and reorganizes code in the `mpack_encode` dispatch, following the same optimization already applied to the JSON encoder. On my machine this results in up to a 15% speedup in encoding speed. Inlining is done selectively, only in collections where the value types are likely to be homogenous (resulting in better branch prediction). The increase in library size is tiny (136 bytes), and no regressions were found in our benchmark suite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This selectively inlines and reorganizes code in the
mpack_encodedispatch, following the same optimization already applied to the JSON encoder (#294).On my machine this results in up to a 15% speedup in encoding speed.
Inlining is done selectively, only in collections where the value types are likely to be homogenous (resulting in better branch prediction). The increase in library size is tiny (136 bytes), and no regressions were found in our benchmark suite.