Work around spurious mypy test errors - #383
Merged
Merged
Conversation
Not sure why, but the mypy tests have suddenly started failing in CI only. The failure is due to type stubs missing for an optional dependency (the type stubs should only be needed for type checking the internals of `msgspec`, not checking user usage of it). I cannot reproduce these issues locally. By checanging around our type annotations and adding a few `type: ignore` comments, I believe this change should resolve the issues on CI.
jcrist
force-pushed
the
work-around-spurious-mypy-errors
branch
from
April 20, 2023 02:09
629f143 to
00eb7c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why, but the mypy tests have suddenly started failing in CI only. The failure is due to type stubs missing for an optional dependency (the type stubs should only be needed for type checking the internals of
msgspec, not checking user usage of it). I cannot reproduce these issues locally.By changing around our type annotations and adding a few
type: ignorecomments, I believe this change should resolve the issues on CI.