Improve JSON str encode performance - #459
Merged
Merged
Conversation
This improves the performance of encoding JSON strings, mostly by rearranging some work and unrolling some loops.
Member
Author
|
A quick benchmark of string performance: import random
import string
from time import perf_counter_ns
from orjson import dumps
from msgspec.json import encode
CHARS = string.ascii_letters
CHARS_WITH_ESCAPES = "\x01\n'\"" + string.ascii_letters
def randstr(chars):
k = random.randint(2, 64)
return "".join(random.choices(chars, k=k))
N = 1000
M = 10000
random.seed(42)
for header, chars in [("No Escapes:", CHARS), ("With Escapes:", CHARS_WITH_ESCAPES)]:
print(header)
data = [randstr(chars) for _ in range(N)]
start = perf_counter_ns()
for _ in range(M):
encode(data)
stop = perf_counter_ns()
print(f"- msgspec: {(stop - start) / (1000 * M):.1f} us")
start = perf_counter_ns()
for _ in range(M):
dumps(data)
stop = perf_counter_ns()
print(f"- orjson: {(stop - start) / (1000 * M):.1f} us")Before This PR Notes:
Even though this PR unrolls some loops, it actually results in a (negligible) decrease in binary size since we delete a non-inlined helper function for handling the escape code case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This improves the performance of encoding JSON strings, mostly by rearranging some work and unrolling some loops.