Try getattr first in convert(mapping, from_attributes=True) - #519
Merged
Merged
Conversation
Previously if a mapping was passed to `convert`, values would only be extracted via `PyObject_GetItem` even if `from_attributes=True`. Some object types define `__getitem__` but also store data via attribute. In this case we want to try `PyObject_GetAttr` first, falling back to `PyObject_GetItem`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously if a mapping was passed to
convert, values would only be extracted viaPyObject_GetItemeven iffrom_attributes=True. Some object types define__getitem__but also store data via attribute. In this case we want to tryPyObject_GetAttrfirst, falling back toPyObject_GetItem.