Conversation
ofek
force-pushed
the
lto
branch
2 times, most recently
from
November 16, 2025 15:52
9a3f12f to
7d7edee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full LTO seems to cause a regression so this uses ThinLTO only on macOS (Clang) and only on ARM64. Here are the results of a few runs (the Intel runners just seem terrible):
Before
ARM64
encode: 145.9584 / decode: 351.2980
https://github.com/jcrist/msgspec/actions/runs/19412999871/job/55537240877
encode: 143.2750 / decode: 354.1458
https://github.com/jcrist/msgspec/actions/runs/19412999871/job/55539651179
x86_64
encode: 228.6268 / decode: 729.5701
https://github.com/jcrist/msgspec/actions/runs/19412999871/job/55537240884
encode: 230.9933 / decode: 757.6821
https://github.com/jcrist/msgspec/actions/runs/19412999871/job/55539352389
After
ARM64
encode: 137.4250 / decode: 341.0833
https://github.com/jcrist/msgspec/actions/runs/19413142685/job/55537726515
encode: 143.0917 / decode: 341.9875
https://github.com/jcrist/msgspec/actions/runs/19413142685/job/55539646141
x86_64
encode: 224.2774 / decode: 690.9108
https://github.com/jcrist/msgspec/actions/runs/19413142685/job/55537726518
encode: 339.4682 / decode: 924.6652
https://github.com/jcrist/msgspec/actions/runs/19413142685/job/55539486694