str_getcsv returns null byte for unterminated quoted string #11982

Activity

1. apeschar

   added

   Bug

   Status: Needs Triage

   on Aug 15, 2023
2. Girgias commented on Aug 15, 2023

   

   Girgias

   on Aug 15, 2023

   Member

   More actions

   This behaviour dates back to its introduction in PHP 5.3, at this point I think the ship has sailed on "sensible" behaviour for this function. I really need to go back and work onext/csv.

   But @bukka what do you think about this?
3. bukka commented on Aug 24, 2023

   

   bukka

   on Aug 24, 2023

   Member

   More actions

   I have done some debugging and I think this might be actually a bug that is worth a fix. I see the point about the BC as some apps might potentially rely on that but I think we could still fix it in 8.3 potentially. Specifically this output really does not make any sense to me:

   <?php
   var_dump(str_getcsv('"","a'));
   var_dump(str_getcsv('"","'));
   

   results to

   array(2) {
     [0]=>
     string(0) ""
     [1]=>
     string(1) "a"
   }
   array(2) {
     [0]=>
     string(0) ""
     [1]=>
     string(1) ""
   }
   

   As can be seen the current logic is to ignore missing enclosing character at the end. But in the case of empty strings, it prints \0 which seems like a omission in the code to me as it twice increments bptr without checking for end.
4. bukka

   added a commit that references this issue on Aug 25, 2023

   Fix phpGH-11982: str_getcsv returns null byte for unterminated quoted…

   ...

   This issue will close once commit e0dc5bd is merged into the 'master' branch.

   e0dc5bd
5. bukka commented on Aug 25, 2023

   

   bukka

   on Aug 25, 2023

   Member

   More actions

   The fix for this is in GH-12047 . It took me quite a bit of time to just figure out how that old (created 20 years ago) parser works. At least I have got some knowledge of that now...
6. bukka

   closed this as completedin aff46d7on Aug 28, 2023
7. bukka

   added

   Extension: standard

   and removed

   Status: Needs Triage

   on Aug 28, 2023
8. bwoebi

   added a commit that references this issue on Jan 31, 2024

   Fix phpGH-11982: str_getcsv returns null byte for unterminated quoted…

   ...

   This issue will close once commit aff46d7 is merged into the 'master' branch.

   aff46d7