Remove ability to import case-insensitive constants from typelibs#3836
Closed
cmb69 wants to merge 2 commits into
Closed
Remove ability to import case-insensitive constants from typelibs#3836cmb69 wants to merge 2 commits into
cmb69 wants to merge 2 commits into
Conversation
Member
Author
|
Shouldn't we remove the parameter/ini setting in the first place (same for define())? |
According to commit 23a5be3[1], we remove the ability to import case- insensitive constants, but do not remove the now superfluous parameter and ini setting. [1] <http://git.php.net/?p=php-src.git;a=commit;h=23a5be3696f4d92e1b18fd59f3ac63c6a15ea12a>
025e1fb to
06cd89d
Compare
nikic
reviewed
Feb 15, 2019
nikic
approved these changes
Feb 19, 2019
Member
Author
|
Applied as f04cf7a. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to commit 23a5be3[1], we remove the ability to import case-
insensitive constants, but do not remove the now superfluous parameter
and ini setting.
[1] http://git.php.net/?p=php-src.git;a=commit;h=23a5be3696f4d92e1b18fd59f3ac63c6a15ea12a