Add Windows CI steps - #2792
Conversation
e2ba6d5 to
60a9aa3
Compare
|
Looks like we'd need to track down whatever is blocking forever, but this would be great to have as a permitted failure job |
|
Yes. It doesn't block locally. Will see what I can find. Also, a lot of tests fail due to different line endings. I can fix some, but an easy fix would be to use a line ending independent assertEquals. How do you feel about that? |
|
I've made it so that the windows job does not fail the workflow (as per GitHub docs). I'll wait for phpactor/test-utils#13 to be merged and then see how for we are. A lot of tests can pass if the work dir is checked out with LF instead of CRLF, but a bunch of tests just need more work... E.g.: phpstan seems to behave differently on Windows... |
|
@dantleech rebased ... let me know what you think about this patch. I can keep updating it for now and try to fix more tests, or we can merge it as is... |
No description provided.