Conversation
- `react-aria` と `react-stately` をpeerDependencies対応のため追加 - 既存のv1テーマ構成を維持するため、 `@charcoal-ui/theme/css/v1/remap.css` をインポート
The package has been unused since the three-vrm-animation migration in October 2024.
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The updated typescript-eslint peer dependency constraint (typescript <6.1.0) conflicts with the current typescript version range (^6.0.3), which can lead to install-time resolution issues.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates application dependencies (notably Charcoal UI, Next.js, React, and tooling) and adjusts the app’s global styles to align with the upgraded UI theme package.
Changes:
- Bump
@charcoal-ui/*packages to6.1.0and update related React ecosystem dependencies. - Add
@charcoal-ui/theme/css/v1/remap.cssimport to the Next.js custom App for updated theme CSS behavior. - Refresh lockfile to reflect updated dependency tree (including adding
react-aria/react-stately).
File summaries
| File | Description |
|---|---|
pages/_app.tsx |
Adds Charcoal theme remap CSS import required by the updated theme package. |
package.json |
Updates dependency versions; adds react-aria and react-stately alongside Charcoal v6. |
package-lock.json |
Syncs lockfile with the new versions and peer dependency structure. |
Review details
- Files reviewed: 2/3 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "styled-components": "^6.0.5", | ||
| "styled-components": "^6.5.3", | ||
| "three": "^0.184.0", | ||
| "typescript": "^6.0.3" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR bumps several dependencies.
See the commit log for details.