Add SelectMenu selectors back - #916
Merged
Merged
Conversation
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://primer-css-git-select-menu-keep-selectors.primer.now.sh |
shawnbot
approved these changes
Sep 30, 2019
shawnbot
left a comment
Contributor
There was a problem hiding this comment.
It's definitely cheating, but let's roll with it 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #900. It adds the removed selectors back. It's a workaround to pass the "test deprecations" check.
A "CSS comment" is used to pass the "block-no-empty" lint rule.