Skip to content

Add link to the Stylelint guide - #989

Merged
simurai merged 1 commit into
release-14.1.0from
stylelint-guide
Dec 17, 2019
Merged

Add link to the Stylelint guide#989
simurai merged 1 commit into
release-14.1.0from
stylelint-guide

Conversation

@simurai

@simurai simurai commented Nov 26, 2019

Copy link
Copy Markdown
Contributor

This adds a link to the Stylelint guide added in https://github.com/github/design-systems/pull/735.

/cc @primer/ds-core

@vercel

vercel Bot commented Nov 26, 2019 •
edited
Loading

Copy link
Copy Markdown

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/primer/primer-css/8tuw3551r
🌍 Preview: https://primer-css-git-stylelint-guide.primer.now.sh

@simurai
simurai changed the base branch from master to release-14.1.0 December 17, 2019 00:43
@simurai
simurai requested a review from jonrohan December 17, 2019 00:54
jonrohan
jonrohan approved these changes Dec 17, 2019
View reviewed changes

@jonrohan jonrohan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should pull the whole stylelint file into primer.style instead of linking to it?

It seems like good content to show off to other teams. ⚡️ 😎

@simurai

simurai commented Dec 17, 2019

Copy link
Copy Markdown
Contributor Author

I wonder if we should pull the whole stylelint file into primer.style instead of linking to it?

Hmm.. Was thinking about that too. But it feels a bit odd talking about scripts used internally for another repo (github/github). If we wanted to show off about it, maybe writing a blog post or doing a talk with demos would be more helpful?

Anyways, I'll merge this for now. It's more meant for Hubbers to point them in the right direction.

@simurai
simurai merged commit 1940982 into release-14.1.0 Dec 17, 2019
@simurai
simurai deleted the stylelint-guide branch December 17, 2019 11:07
@simurai simurai mentioned this pull request Dec 17, 2019
Merged
6 tasks
@github-actions github-actions Bot mentioned this pull request Nov 28, 2022
Open
This was referenced Dec 23, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonrohan jonrohan jonrohan approved these changes

Assignees

No one assigned

Labels

patch release Tag: Documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simurai @jonrohan