Conversation
Less code, more passing tests.
Member
Author
|
I mostly wrote this PR to show that backporting the folding algorithm from Python 3 to Python 2 is a very bad idea: it breaks almost all test_email tests... It changes all email headers in many different ways. |
vstinner
commented
Nov 7, 2018
| """ | ||
| # See which encoding we should use. | ||
| codec = self.output_codec or 'us-ascii' | ||
| _encode = lambda a, b: self.convert(a) |
Member
Author
There was a problem hiding this comment.
This is my hack, it looks wrong :-)
Member
Author
There was a problem hiding this comment.
test_email_codecs fails on this lambda function :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Less code, more passing tests.
https://bugs.python.org/issue11492