Suppress redundant --server-name warning when names match - #7187
Open
Shasha-17 wants to merge 1 commit into
Open
Suppress redundant --server-name warning when names match#7187Shasha-17 wants to merge 1 commit into
Shasha-17 wants to merge 1 commit into
Conversation
clovergaze
approved these changes
Jan 27, 2026
clovergaze
left a comment
There was a problem hiding this comment.
Looks good to me, as in functionally the same with more checks 👍
Author
|
TFTR @clovergaze |
Member
|
@Shasha-17 in order to avoid signing Contributor Agreements, we have to make sure the commits are signed off. I restored the PR description's checklist part. Could you please make sure to sign-off the commit ( Otherwise, this looks good to merge once done. |
Signed-off-by: Shasha-17 <73274457+Shasha-17@users.noreply.github.com>
Shasha-17
force-pushed
the
fix-server-name-warning
branch
from
March 28, 2026 18:41
b461bce to
e20dabd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change suppresses a redundant startup warning when the configured
--server-name matches the name already stored in server metadata.
The warning is now only emitted when the names differ.
Fixes #6922
Checklist
added
Signed-off-by: <YOUR NAME>to the commit trail where<YOUR NAME>ismy name.