Make ContainerQueryListController a Document supplement - #62626
Draft
chromium-wpt-export-bot wants to merge 1 commit into
Draft
Make ContainerQueryListController a Document supplement#62626chromium-wpt-export-bot wants to merge 1 commit into
chromium-wpt-export-bot wants to merge 1 commit into
Conversation
Follow-up to [1]. Attach the controller to Document instead of LocalDOMWindow, so null check no longer need. Added tests cover that matches and change events stay correct after the target is adopted into another document. [1] https://chromium-review.googlesource.com/c/chromium/src/+/8255022/comment/616642a6_cd704fd3/ Bug: 40887402 Change-Id: I33ea44db6d58776112dc37c0d8320af777940e66
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to [1]. Attach the controller to Document instead of
LocalDOMWindow, so null check no longer need.
Added tests cover that matches and change events stay correct
after the target is adopted into another document.
[1] https://chromium-review.googlesource.com/c/chromium/src/+/8255022/comment/616642a6_cd704fd3/
Bug: 40887402
Change-Id: I33ea44db6d58776112dc37c0d8320af777940e66
Reviewed-on: https://chromium-review.googlesource.com/8374242
WPT-Export-Revision: 3207fa800eb675c2e1c899bc91bb43127cdb2307