Fix the localization tests for Release Automation - #27944
Merged
Dongbo Wang (daxian-dbw) merged 1 commit intoSep 1, 2026
Merged
Fix the localization tests for Release Automation#27944Dongbo Wang (daxian-dbw) merged 1 commit into
Dongbo Wang (daxian-dbw) merged 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Dongbo Wang (daxian-dbw)
September 1, 2026 22:06
View session
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new skip conditions are partly gated on a newly introduced pipeline environment variable and don’t fully implement the PR’s stated “MSIX-installed pwsh only” behavior outside Release Automation.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates localization-focused Pester tests so they don’t fail in Release Automation scenarios where required repo artifacts or installed satellite resources aren’t present.
Changes:
- Add conditional skipping for
LocProject.jsonvalidation tests intended to run only from a full local repo checkout. - Add conditional skipping for satellite assembly validation so it only runs when appropriate for the installed PowerShell context.
File summaries
| File | Description |
|---|---|
test/powershell/engine/ResourceValidation/LocProject.Tests.ps1 |
Adds Release-Automation-aware skipping and makes JSON loading errors terminating. |
test/powershell/engine/ResourceValidation/LocalizedResource.Tests.ps1 |
Adds conditional skip logic for satellite assembly validation based on environment/install type. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Justin Chung (jshigetomi)
approved these changes
Sep 1, 2026
Dongbo Wang (daxian-dbw)
merged commit Sep 1, 2026
fcdb9f0
into
PowerShell:master
37 of 38 checks passed
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the localization tests for Release Automation.
LocProject.jsontests depend on theLocProject.jsonfile is available, which is not the case for Release Automation. So, they should be skipped for Release Automation.